Improve unmarshalling and implement a RetryFunc #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
force-pushed
the
f/unmarshalling-and-retries
branch
2 times, most recently
from
c1e9de0 to
c9b0ac7
Compare
manicminer
commented
Feb 20, 2024
Comment on lines
+52
to
+66
| respBody, err := io.ReadAll(resp.Body) | ||
| if err != nil { | ||
| return false, fmt.Errorf("could not parse response body") | ||
| } | ||
| resp.Body.Close() | ||
| respBody = bytes.TrimPrefix(respBody, []byte("\xef\xbb\xbf")) | ||
| res := ErrorResponse{} | ||
| if err = xml.Unmarshal(respBody, &res); err != nil { | ||
| return false, err | ||
| } | ||
| resp.Body = io.NopCloser(bytes.NewBuffer(respBody)) | ||
| if res.Code != nil { | ||
| return strings.Contains(*res.Code, "ContainerBeingDeleted"), nil | ||
| } |
There was a problem hiding this comment.
Note: it might be worth changing RetryFunc so that it's passed a client.Response rather than an http.Response, which would make common parsing a little cleaner. I can do that as part of this change if anyone thinks that's warranted? Or we could do that later when more RetryFuncs are added.
Merged
9 tasks
tombuildsstuff
approved these changes
Feb 20, 2024
go.mod
Outdated
| github.com/hashicorp/go-azure-sdk/resource-manager v0.20240125.1111756 | ||
| github.com/hashicorp/go-azure-sdk/sdk v0.20240125.1115017 | ||
| github.com/hashicorp/go-azure-sdk/sdk v0.20240219.1162257-0.20240220115734-eeb1a5d96f9a |
There was a problem hiding this comment.
wants updating to a stable version
…p/go-azure-sdk/sdk` and v0.66.2 of `github.com/hashicorp/go-azure-helpers`
manicminer
force-pushed
the
f/unmarshalling-and-retries
branch
from
e57d964 to
dfec5fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: hashicorp/go-azure-sdk#890